Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade yarn in docker images to 1.22.22 #1036

Closed
vadimpopa opened this issue Apr 19, 2024 · 8 comments · Fixed by #1071
Closed

Please upgrade yarn in docker images to 1.22.22 #1036

vadimpopa opened this issue Apr 19, 2024 · 8 comments · Fixed by #1071
Assignees

Comments

@vadimpopa
Copy link

What would you like?

There's yarn 1.22.22 but the images are on 1.22.19 https://hub.docker.com/layers/cypress/included/13.8.0/images/sha256-8fd74c146e3f3b0ae33f9d2864cbe7e2068434df24fc35abff913c9505eea59a?context=explore

Please upgrade yarn. Thanks

Why is this needed?

No response

Other

No response

@jennifer-shehane jennifer-shehane transferred this issue from cypress-io/cypress Apr 19, 2024
@jennifer-shehane
Copy link
Member

Transferred this issue to the cypress-docker-images repo

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Apr 19, 2024

This can be updated here and requires a new release of the factory:

# Yarn versions: https://www.npmjs.com/package/yarn

Publish new factory: https://github.com/cypress-io/cypress-docker-images/blob/master/CONTRIBUTING.md#automatic

We're open to a pull request to update this.

This issue may be related: #1031

@jennifer-shehane jennifer-shehane added the good first issue Good for newcomers label Apr 19, 2024
@MikeMcC399
Copy link
Collaborator

The stable version of Yarn is still 1.22.19 according to https://classic.yarnpkg.com/latest-version and https://classic.yarnpkg.com/en/docs/install.

The reference node Docker images contain Yarn 1.22.19 (and not any later version) for this reason.

The scripts to install Yarn v1 in the Cypress Docker images (factory/installScripts/yarn/default.sh) rely on the availability of a PGP signature file (.asc) and Yarn did not make this file available for any releases after v1.22.19 published two years ago.

If the Yarn team provides some response to the following two issues, then it should be easier to decide what to do with the Yarn v1 version in the Cypress Docker images:

Note that Yarn v1 Classic has been in maintenance mode since January 2020 (see https://classic.yarnpkg.com/en/docs/install) and there is no longer any focus on supporting this version, although an official end-of-life has not yet been declared.

@vadimpopa
Copy link
Author

Hi @MikeMcC399 ,

yeah, I saw that when I tried to push a PR on this. We are migrating from yarn v1 to sth else...so up to you if you want to close or keep open this issue.

@MikeMcC399
Copy link
Collaborator

@vadimpopa

We are migrating from yarn v1 to sth else...so up to you if you want to close or keep open this issue.

I'm trying to get some clarity from through the Yarn v1 issues about what to expect from them, so I don't suggest closing this issue for the moment.

Migrating away from Yarn v1 Classic would be a good move for end-users in any case!

@MikeMcC399
Copy link
Collaborator

@Daniel15
Copy link

I've uploaded a GPG signature for Yarn v1.22.22, along with all other missing artifacts (.deb, .rpm, and Windows installer). This should be good to go now.

@MikeMcC399
Copy link
Collaborator

Thank you @Daniel15 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants