CircleCI test-deploy workflow uses end-of-life Node.js 16

[MikeMcC399]

The CircleCI workflow .circleci/test-deploy.yml is configured to use the Docker container:

cypress/browsers:node-16.18.1-chrome-109.0.5414.74-1-ff-109.0-edge-109.0.1518.52-1

whereas the executor has been updated to node-version: "20.6.0".

Node.js 16 already reached end-of-life on Sep 11, 2023 and is no longer supported.

(Runs are logged to https://app.circleci.com/pipelines/github/cypress-io/circleci-orb.)

Suggestion

Use a minimum Node.js 18.x version compatible with the examples/angular-app version installed.

[MikeMcC399]

It seems that https://app.circleci.com/pipelines/github/cypress-io/circleci-orb is not currently being triggered.

[jennifer-shehane]

@MikeMcC399 Yes, I did notice this. I briefly looked at it but have no idea why.

• Our circleci-orb CI runs are never running. chore: set circleci browser tools orb to pull v1 with updates #449
• Nothing has run since a commit 2 months ago that didn’t touch the Circle config: https://app.circleci.com/pipelines/github/cypress-io/circleci-orb
• The CircleCI/GitHub webhook delivery looks fine: https://github.com/cypress-io/circleci-orb/settings/hooks/62000836?tab=deliveries

[jennifer-shehane]

@MikeMcC399 Figured it out with some help! #449 (comment)

[MikeMcC399]

@jennifer-shehane

Thank you for taking a look at this. I can't be much help as I'm inexperienced with CircleCI and I don't have visibility into the CircleCI settings https://github.com/cypress-io/circleci-orb/settings either.

[MikeMcC399]

Since

circleci-orb/examples/angular-app/package.json

Line 27 in aa59916

"@angular/cli": "~15.1.4",

is currently using Angular 15, this restricts Node.js to ^14.20.0 || ^16.13.0 || ^18.10.0 according to Angular > Version compatibility.

Angular 15 reaches end-of-life on May 18, 2024 so at some stage a migration to at least Angular 16 (supports Node.js ^16.14.0 || ^18.10.0) or preferably Angular 17 (supports Node.js ^18.13.0 || ^20.9.0) should be planned.

• Edit: This comment has been transferred to Angular 15 in examples is unsupported #470

[jordanpowell88]

Did #449 close this issue @jennifer-shehane ?

[MikeMcC399]

@jordanpowell88

Did #449 close this issue?

• chore: set circleci browser tools orb to pull v1 with updates #449 is unrelated

https://github.com/cypress-io/circleci-orb/blob/master/.circleci/test-deploy.yml still contains the following usage of the now unsupported Node.js 16 version:

circleci-orb/.circleci/test-deploy.yml

Lines 24 to 26 in 6fe76b4

	run-ct-tests-in-chrome:
	docker:
	- image: cypress/browsers:node-16.18.1-chrome-109.0.5414.74-1-ff-109.0-edge-109.0.1518.52-1

circleci-orb/.circleci/test-deploy.yml

Lines 35 to 37 in 6fe76b4

	run-ct-tests-in-firefox:
	docker:
	- image: cypress/browsers:node-16.18.1-chrome-109.0.5414.74-1-ff-109.0-edge-109.0.1518.52-1

circleci-orb/.circleci/test-deploy.yml

Lines 46 to 48 in 6fe76b4

	run-ct-tests-in-edge:
	docker:
	- image: cypress/browsers:node-16.18.1-chrome-109.0.5414.74-1-ff-109.0-edge-109.0.1518.52-1

This issue therefore remains unaddressed.