Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make filter controls "sticky" #991

Open
MetRonnie opened this issue Apr 8, 2022 · 1 comment
Open

Make filter controls "sticky" #991

MetRonnie opened this issue Apr 8, 2022 · 1 comment
Labels
small UX/UI User experience and interface improvements
Milestone

Comments

@MetRonnie
Copy link
Member

Describe exactly what you would like to see in an upcoming release
Pin the filter controls to the top of the lumino tree & table views so they don't scroll out of view.

From Hilary on Element:

Anyone noticed this cylc-ui regression?

We merged this PR late January: #861

As I recall it pinned the filter view toolbars to the top of the lumino tabs, for table and tree view - i.e. independent of view scrolling.

However, since then (and possibly for rc1 which was released not long after) the tool bars have become unpinned again.

Looks like the regression occurred on the PR itself. I just built cylc-ui on the first commit of that branch, and the filter toolbar was pinned to the top of the table view at that point.

Pull requests welcome!

@MetRonnie MetRonnie added this to the 1.2.0 milestone Apr 8, 2022
@MetRonnie MetRonnie modified the milestones: 1.2.0, 1.3.0 May 3, 2022
@oliver-sanders oliver-sanders modified the milestones: 1.3.0, 1.4.0, 1.x, Pending Jun 8, 2022
@oliver-sanders oliver-sanders added UX/UI User experience and interface improvements and removed enhancement labels Oct 17, 2022
@oliver-sanders
Copy link
Member

oliver-sanders commented Oct 17, 2022

Note: The search & filter controls (along with any other controls a view needs) are intended to be combined into a "view toolbar" - #471

This toolbar would be "sticky" at the top of the view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small UX/UI User experience and interface improvements
Projects
None yet
Development

No branches or pull requests

2 participants