Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slow to load with large numbers of workflows #866

Closed
oliver-sanders opened this issue Dec 8, 2021 · 2 comments
Closed

slow to load with large numbers of workflows #866

oliver-sanders opened this issue Dec 8, 2021 · 2 comments

Comments

@oliver-sanders
Copy link
Member

When you start the GUI the number of workflows displayed on the dashboard, starting at 0 and incrementing one by one.

It's a fairly fast process, however, if you have > ~30 workflows it takes a little while. The GUI is somewhat unresponsive during this period.

We should do something to improve this load time.

I think the cause is probably the delta processing time.

A possible solution would be to batch up the workflow-added deltas at the UIS so that all workflows arrive together at startup. This might cut out render stage from the workflow-added loop?

Pull requests welcome!

@oliver-sanders oliver-sanders added this to the 1.x milestone Dec 8, 2021
@kinow
Copy link
Member

kinow commented Dec 8, 2021

A possible solution would be to batch up the workflow-added deltas at the UIS so that all workflows arrive together at startup. This might cut out render stage from the workflow-added loop?

I think this would be a good fix. Maybe in the future, if needed, the updated/pruned deltas could be batched and the throughput controlled in the UIS too (i.e. accumulate these deltas types and send to the UI every 300ms or some other configured interval, instead of sending everything whenever it's available).

That could reduce the number of times the UI needs to process messages from the UIS, update internal data, and tell Vue to update the VDOM and DOM too.

@oliver-sanders oliver-sanders modified the milestones: 1.x, Pending Jun 8, 2022
@oliver-sanders
Copy link
Member Author

Closing this in favour of the more detailed #947

@oliver-sanders oliver-sanders removed this from the Pending milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants