Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI reporting incorrectly that a delta is not in the lookup #747

Closed
kinow opened this issue Aug 31, 2021 · 2 comments · Fixed by #749
Closed

UI reporting incorrectly that a delta is not in the lookup #747

kinow opened this issue Aug 31, 2021 · 2 comments · Fixed by #749
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kinow
Copy link
Member

kinow commented Aug 31, 2021

Describe the bug

From Element, reported today by @dwsutherland . In the screenshot below, it's possible to see an alert error message for a delta missing from the lookup. But since we have the updated and pruned deltas, both in the same delta, it should be already in the lookup map.

Unless... it never arrived in an added delta? But in this case maybe we are adding nodes in updated too? Will have to confirm.

Release version(s) and/or repository branch(es) affected?

master

Steps to reproduce the bug

Expected behavior

Screenshots

image

Additional context

Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read CONTRIBUTING.md before starting any work though).

@kinow kinow added the bug Something isn't working label Aug 31, 2021
@kinow kinow added this to the 0.6.0 milestone Aug 31, 2021
@hjoliver
Copy link
Member

hjoliver commented Sep 1, 2021

Any workflow with a family above root seems to generate this error.

This one does it every time a new cycle point is spawned:

[scheduling]
  cycling mode = integer
  initial cycle point = 1
  runahead limit = P1
  [[graph]]
     P1 = "f1"
[runtime]
  [[FAM]]
  [[f1]]
     inherit = FAM

@kinow kinow self-assigned this Sep 1, 2021
@hjoliver
Copy link
Member

hjoliver commented Sep 1, 2021

Detail from the browser console:

Updated node [oliverh|fam/run5|49|FAM] not found in workflow lookup 
{id: 'oliverh|fam/run5|49|FAM', state: 'running', __typename: 'FamilyProxy'}
id: "oliverh|fam/run5|49|FAM"
state: "running"
__typename: "FamilyProxy"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants