Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate summary state up the tree in GScan #721

Open
kinow opened this issue Aug 3, 2021 · 2 comments
Open

Propagate summary state up the tree in GScan #721

kinow opened this issue Aug 3, 2021 · 2 comments
Assignees
Milestone

Comments

@kinow
Copy link
Member

kinow commented Aug 3, 2021

Describe exactly what you would like to see in an upcoming release

As a follow-up, we should have a summary state propagate up the tree (so you can see if anything is running in a collapsed branch...)

Additional context

Follow-up from #502

Pull requests welcome!

@kinow kinow added this to the 0.6.0 milestone Aug 3, 2021
@kinow kinow mentioned this issue Aug 3, 2021
6 tasks
@kinow
Copy link
Member Author

kinow commented Aug 17, 2021

Note on what must be displayed in the parent nodes to a workflow, via @hjoliver :

It should be job icons like the current workflow state totals, but made by combining the state totals all the workflows underneath. It's probably reasonable to just have the number of tasks for each item, and you can expand to tree to see the "recent tasks" info (otherwise we'd need to preface task ID with workflow name...)

So, in this "family" of workflows there are currently two failed tasks and six running etc.

@kinow kinow self-assigned this Aug 17, 2021
@kinow kinow mentioned this issue Aug 17, 2021
6 tasks
@kinow
Copy link
Member Author

kinow commented Aug 18, 2021

From today's chat at Element with @hjoliver :

So we don't allow nested run directories, but we can have a directory hierarchy with workflows at multiple different levels ... >which means the aggregation result won't be the same at each level.
So as a first cut, maybe you should just display it at every level like in your screenshot above.

The screenshot mentioned:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants