Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning icons ⚠️ #632

Closed
oliver-sanders opened this issue Mar 26, 2021 · 2 comments
Closed

warning icons ⚠️ #632

oliver-sanders opened this issue Mar 26, 2021 · 2 comments

Comments

@oliver-sanders
Copy link
Member

requires: cylc/cylc-flow#4148

In the Cylc7 GUI there is a warning icon in the bottom right-hand corner which lights up whenever
a "warning" or higher is written to the log (I think it's warning, it might be "error" would have to look).
The user can click on the icon to open the log / dismiss it.

In the Cylc7 GScan there is a warning icon next to each workflow which appears next to the suite whenever
a task enters the failed or submit-failed statues. The user can then click on the icon to dismiss it.

For the Cylc8 GUI we should have a latest warnings stream from the Scheduler - cylc/cylc-flow#4148

Suggest the following:

  • Warnings should be displayed in GScan to the left of the task-state icons.
    • There is a warning icon component already implemented @/components/cylc/WarningIcon.
    • On hover a tooltip should list recent warnings.
    • On click the icon should be dismissed (turn greyscale, already implemented).
  • The dashboard page should list these warnings.
    • We can probably do something more advanced there later.

Pull requests welcome!

@oliver-sanders oliver-sanders added this to the 1.0 milestone Mar 26, 2021
@kinow kinow modified the milestones: 1.0, 2.0 Sep 10, 2021
@oliver-sanders oliver-sanders modified the milestones: 2.0.0, Pending Jun 8, 2022
@oliver-sanders oliver-sanders mentioned this issue Oct 27, 2022
8 tasks
@dpmatthews
Copy link

Duplicate of #535?

@oliver-sanders
Copy link
Member Author

This issue leans more toward the Cylc 7 GScan warning icon (one per-workflow) which is activated by task failures.

#535 leans more toward the Cylc 7 GCylc warning icon (bottom right corner) which is activated by log messages ar WARNING level or higher.

I think log level should be the better option, although may require a bit of fiddling with log messages to ensure that recoverable warnings are emitted at INFO level to avoid false positives.

Closing as duplicate of #535

@MetRonnie MetRonnie removed this from the Pending milestone Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants