Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reload: address warning for preparing tasks #4990

Closed
oliver-sanders opened this issue Jul 20, 2022 · 3 comments · Fixed by #5109
Closed

reload: address warning for preparing tasks #4990

oliver-sanders opened this issue Jul 20, 2022 · 3 comments · Fixed by #5109
Assignees
Milestone

Comments

@oliver-sanders
Copy link
Member

Address warning for preparing tasks post-reload.

We think after a reload preparing tasks may, or may not, be active with pre-reload settings as the job file may, or may not, have been written. Needs a little investigation and a LOG.warning worded as appropriate.

See #4984 (comment)

Pull requests welcome!

@MetRonnie
Copy link
Member

MetRonnie commented Aug 30, 2022

I have looked into this and cannot tell for sure whether a job file would have been written at the point of doing a reload. So having a different warning for preparing tasks saying they "may" be active with pre-reload settings seems sensible.

Possibly we could look at

... be specific by flagging if the job file was written yet, or not.

at a later milestone?

@oliver-sanders
Copy link
Member Author

Sounds good.

I think the mid/long term solution here is probably to flush through preparing tasks before performing the reload for safety.

@MetRonnie
Copy link
Member

MetRonnie commented Aug 31, 2022

Closing as partially addressed by #5109, with the long term part being superseded by #5107

@MetRonnie MetRonnie linked a pull request Aug 31, 2022 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants