Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job runner comand template not being used #4987

Closed
hjoliver opened this issue Jul 19, 2022 · 4 comments
Closed

job runner comand template not being used #4987

hjoliver opened this issue Jul 19, 2022 · 4 comments
Assignees
Labels
bug Something is wrong :( invalid

Comments

@hjoliver
Copy link
Member

hjoliver commented Jul 19, 2022

There are some functional tests that purport to test this, but they require job runner at, so perhaps no one is running them at the moment.

$ git grep "job runner command template" tests/*functional
tests/flakyfunctional/job-submission/19-chatty.t:        job runner command template = talkingnonsense %(job)s
tests/functional/cylc-poll/02-task-submit-failed.t:        job runner command template = at noon tomorrow
tests/functional/job-submission/09-activity-log-host-bad-submit.t:        job runner command template = at non
tests/functional/job-submission/16-timeout.t:        job runner command template = sleep 30
tests/functional/reload/20-stop-point.t:        job runner command template = sleep 5
tests/functional/restart/05-submit-failed.t:        job runner command template = at oh-no
@hjoliver hjoliver added the bug Something is wrong :( label Jul 19, 2022
@hjoliver hjoliver added this to the cylc-8.0.1 milestone Jul 19, 2022
@hjoliver hjoliver self-assigned this Jul 19, 2022
@MetRonnie
Copy link
Member

All of those are passing for me

@oliver-sanders oliver-sanders modified the milestones: cylc-8.0.1, 8.0.2 Aug 16, 2022
@oliver-sanders oliver-sanders modified the milestones: cylc-8.0.2, cylc-8.0.3 Sep 12, 2022
@oliver-sanders oliver-sanders modified the milestones: cylc-8.0.3, cylc-8.0.4 Oct 12, 2022
@oliver-sanders oliver-sanders modified the milestones: cylc-8.0.4, cylc-8.1.x Dec 6, 2022
@MetRonnie MetRonnie modified the milestones: cylc-8.1.x, cylc-8.1.5 May 4, 2023
@hjoliver hjoliver modified the milestones: cylc-8.1.x, cylc-8.2.0 Jun 13, 2023
@oliver-sanders oliver-sanders modified the milestones: cylc-8.2.0, cylc-8.3.0 Jul 11, 2023
@wxtim
Copy link
Member

wxtim commented Dec 12, 2023

I can't replicate this locally. Does it still exist?

@oliver-sanders oliver-sanders modified the milestones: cylc-8.3.0, cylc-8.4.0 Feb 22, 2024
@oliver-sanders
Copy link
Member

Tests all pass.

@hjoliver, we're not sure what the issue is? This one keeps getting bumped back (#4988).

@MetRonnie MetRonnie removed this from the cylc-8.4.0 milestone Feb 22, 2024
@MetRonnie
Copy link
Member

I'm closing as I am pretty sure this is invalid: #4988 (comment)

Re-open if not

@MetRonnie MetRonnie closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :( invalid
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants