Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylc clean: don't bail early on a list of workflows #4934

Closed
hjoliver opened this issue Jun 27, 2022 · 4 comments · Fixed by #4949
Closed

cylc clean: don't bail early on a list of workflows #4934

hjoliver opened this issue Jun 27, 2022 · 4 comments · Fixed by #4949
Assignees
Labels
could be better Not exactly a bug, but not ideal. small
Milestone

Comments

@hjoliver
Copy link
Member

cylc clean shouldn't bail out if it runs into a problem cleaning one workflow in a list (i.e. it should continue on to clean the next ones).

E.g., install and run a workflow that uses a non-existent job platform, then try to clean it and some others using a wildcard.

@hjoliver hjoliver added bug Something is wrong :( small labels Jun 27, 2022
@hjoliver hjoliver added this to the cylc-8.0rc4 milestone Jun 27, 2022
@hjoliver
Copy link
Member Author

See also #4673

@oliver-sanders oliver-sanders added could be better Not exactly a bug, but not ideal. and removed bug Something is wrong :( labels Jun 29, 2022
@oliver-sanders
Copy link
Member

I think we can live with this (provided the non-existant job platform issue can be handled), have downgraded the "bug" label, can we bump this to 8.x?

@hjoliver
Copy link
Member Author

If I ask to clean 3 workflows and it stops at 1, that's a bug innit.

I was expecting this would be a trivial fix, but if not, we can bump it. I'll have a look...

@hjoliver
Copy link
Member Author

hjoliver commented Jun 30, 2022

BTW, I've actually found this one pretty annoying lately. Any functional test that fails and used a fake platform - e.g. the "intelligent host selection" tests broken initially by #4938) - prevents other tests from being cleaned up with cylc clean cylctb* because of this (and #4935).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could be better Not exactly a bug, but not ideal. small
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants