Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detect() method for the tab-size.js #520

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

drugan
Copy link

@drugan drugan commented May 17, 2017

To reproduce:

Put mystyle.css into the project root directory.
mystyle.css.txt

Run:
csscomb -d mystyle.css

Observe:
no-tab-size

Apply the current PR changes, run the command again and observe:
tab-size-detected

@tonyganch
Copy link
Member

Hey @drugan, builds for your detect PRs seem to be failing. Could you please take a look?

@drugan
Copy link
Author

drugan commented Jun 2, 2017

The culprit was in test/options/integral/detect/test.js. This file uses the default csscomb.json to check options' values against but it does not have tab-size option though with the current patch the respective value is detected.

Also, the logic for detect() in the tab-size.js is improved (hopefully).

@tonyganch tonyganch force-pushed the dev branch 3 times, most recently from 359ae56 to f05188a Compare March 24, 2019 05:48
@mariovalney
Copy link
Contributor

Hi! Me again again 😄

Would you can refresh this too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants