Tests: Add helpers #147
Merged
Tests: Add helpers #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Divide tests into 2 folders: core and options. Use mocha programmatically. Add test helpers: `readFile()`, `shouldBeEqual` and `shouldDetect`.
|
rebased |
This was referenced Dec 27, 2013
kizu
added a commit
to kizu/csscomb.js
that referenced
this pull request
Dec 27, 2013
kizu
added a commit
to kizu/csscomb.js
that referenced
this pull request
Dec 27, 2013
kizu
added a commit
to kizu/csscomb.js
that referenced
this pull request
Dec 27, 2013
kizu
added a commit
to kizu/csscomb.js
that referenced
this pull request
Dec 27, 2013
kizu
added a commit
to kizu/csscomb.js
that referenced
this pull request
Dec 28, 2013
kizu
added a commit
to kizu/csscomb.js
that referenced
this pull request
Jan 8, 2014
mishanga
pushed a commit
that referenced
this pull request
Jan 9, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coreandoptions.coreis supposed to collect tests forcli.jsandcsscomb.js.test/mocha.jsand run mocha programmatically.This allows adding helpers for all tests.
Since
bddis default ui anddotis default reporter, remove options.readFile(),shouldBeEqual()andshouldDetect().Good news is we have helpers that can be used in all tests.
Code is simpler and I believe it will be easier to add cases for #89.
The fun part is 2 tests are broken now and skipped: one + two.
Since those cases appear to fail in
devbranch as well when tested manually in console, I assume they have never worked in fact.So I've commented them out and created issues.