-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option Request: space-between-nested-blocks #317
Comments
👍 |
|
@tonyganch, this doesn't work for me :( http://pastebin.ru/mEq1TGhV |
@tonyganch double-checked it, |
Should be fixed in 3.0.3. |
Thank you! |
I'm sorry for closing the issue. I've misread description, it's not fixed really. @PD-WebTools, is this issue somehow related to #210? |
@tonyganch, what are you think about this commit? It looks like solution for this. This issue not exactly related to rule-delimeter and you pointed on this in comment. I've also need this feature and want to try make PR. |
@hudochenkov, can you show a few examples (before and after) to illustrate what you want to achieve? |
@hudochenkov, you want to sort rulesets too? Based on selectors? |
I want to visual separate block's properties, includes, extends and it's children. As I understand, now block's children not participating in sort-order. So it glued with no empty lines with all sort-order effected nodes. If we can identify all block's children as one entity, we can put them in sort-order. Previous implementation of Example config: { "sort-order": [
["position", "top", "left", "margin", "padding", "padding-right", "content"],
["$include desk", "$include palm"],
["$nested-blocks"]
]} Before: .panel {
position: absolute;
top: 0;
left: 0;
&__inner {
padding: 0 8px 0 20px;
&:before {
content: "";
}
}
&__close {
display: block;
}
} After (added two empty lines): .panel {
position: absolute;
top: 0;
left: 0;
&__inner {
padding: 0 8px 0 20px;
&:before {
content: "";
}
}
&__close {
display: block;
}
} Before: .panel {
position: absolute;
top: 0;
left: 0;
@include palm {
position: relative;
}
&__inner {
padding: 0 8px 0 20px;
@include desk {
margin: 0 3.5%;
}
@include palm {
padding-right: 20px;
}
}
&__close {
display: block;
}
} After (added one empty line): .panel {
position: absolute;
top: 0;
left: 0;
@include palm {
position: relative;
}
&__inner {
padding: 0 8px 0 20px;
@include desk {
margin: 0 3.5%;
}
@include palm {
padding-right: 20px;
}
}
&__close {
display: block;
}
} |
👍 |
1 similar comment
+1 |
I would like to suggest an option, space-between-nested-blocks. For my needs, I'd just like to make sure there is a line between my current rules and a nested selector. Example:
Example Source
space-between-nested-blocks = true
The text was updated successfully, but these errors were encountered: