Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vow-fs #229

Closed
cvrebert opened this issue Jun 5, 2014 · 3 comments
Closed

Update vow-fs #229

cvrebert opened this issue Jun 5, 2014 · 3 comments

Comments

@cvrebert
Copy link
Contributor

cvrebert commented Jun 5, 2014

CSSComb currently can't be npm shrinkwraped due to dfilatov/vow-queue#10 , and there's been no progress on fixing that vow-queue issue so far.
So, would it be feasible to remove upgrade vow-fs? and switch to a different library instead?
This is causing us some grief over at Bootstrap; see twbs/bootstrap#13585

@cvrebert cvrebert closed this as completed Jun 6, 2014
@tonyganch tonyganch reopened this Jun 6, 2014
@tonyganch
Copy link
Member

Thanks for a notice.
I'll run some tests and if everything is fine, we can just rearrange dependencies
I'll post an update once there are any news.

@cvrebert cvrebert changed the title Migrate away from vow-fs? Update vow-fs Jun 6, 2014
tonyganch added a commit that referenced this issue Jun 9, 2014
@tonyganch
Copy link
Member

I've released [email protected] with updated vow and vow-fs dependencies.
It should be ok.
There may be some warnings about jscs module dependency, but you can ignore them for now.
As soon as jscs is updated, I'll update csscomb too: jscs-dev/node-jscs#427

Let me know if there is anything else I can help you with.

@cvrebert
Copy link
Contributor Author

cvrebert commented Jun 9, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants