Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong error value returned in Corpus.Initialize #510

Open
samalws-tob opened this issue Nov 22, 2024 · 0 comments
Open

Wrong error value returned in Corpus.Initialize #510

samalws-tob opened this issue Nov 22, 2024 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@samalws-tob
Copy link
Contributor

The return on line 351 should return covErr rather than err. Right now it will return 0, 0, nil

// Set our coverage maps to those collected when replaying all blocks when cloning.
c.coverageMaps = coverage.NewCoverageMaps()
for _, block := range testChain.CommittedBlocks() {
for _, messageResults := range block.MessageResults {
covMaps := coverage.GetCoverageTracerResults(messageResults)
_, _, covErr := c.coverageMaps.Update(covMaps)
if covErr != nil {
return 0, 0, err
}
}
}

@anishnaik anishnaik added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants