Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set IO to be sync for File by default #15236

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Set IO to be sync for File by default #15236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fcf743
Set IO to be synchronous for `File` by default
jgaskins Nov 28, 2024
e764834
Set sync values for Win32 and WASI, as well
jgaskins Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/crystal/system/unix/file_descriptor.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ module Crystal::System::FileDescriptor

private def system_blocking_init(value)
self.system_blocking = false unless value
self.sync = value
end

private def system_close_on_exec?
Expand Down
1 change: 1 addition & 0 deletions src/crystal/system/wasi/file_descriptor.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ module Crystal::System::FileDescriptor
end

private def system_blocking_init(value)
self.sync = value
end

private def system_reopen(other : IO::FileDescriptor)
Expand Down
1 change: 1 addition & 0 deletions src/crystal/system/win32/file_descriptor.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ module Crystal::System::FileDescriptor

private def system_blocking_init(value)
@system_blocking = value
self.sync = value
Crystal::EventLoop.current.create_completion_port(windows_handle) unless value
end

Expand Down
Loading