Handle trailing comma with multiple parameters on the same line

crystal-lang · Oct 18, 2024 · 130efd8 · 130efd8
1 parent dacd97b
commit 130efd8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/spec/compiler/formatter/formatter_spec.cr b/spec/compiler/formatter/formatter_spec.cr
@@ -918,6 +918,13 @@ describe Crystal::Formatter do
     end
     CRYSTAL
 
+  assert_format <<-CRYSTAL
+    def foo(
+      a, b,
+    )
+    end
+    CRYSTAL
+
   assert_format <<-CRYSTAL
     macro foo(
       a,

diff --git a/src/compiler/crystal/tools/formatter.cr b/src/compiler/crystal/tools/formatter.cr
@@ -1651,7 +1651,7 @@ module Crystal
       yield
 
       # Write "," before skipping spaces to prevent inserting comment between argument and comma.
-      write "," if has_more || (wrote_newline && @token.type.op_comma?) || (write_trailing_comma && flag?("def_trailing_comma"))
+      write "," if has_more || (wrote_newline && @token.type.op_comma?) || (write_trailing_comma && flag?("def_trailing_comma")) || (write_trailing_comma && @token.type.op_comma?)
 
       just_wrote_newline = skip_space
       if @token.type.newline?