Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: use same compilation flags as the Docker images #515

Closed
dunglas opened this issue Aug 9, 2024 · 1 comment · Fixed by #556
Closed

Proposal: use same compilation flags as the Docker images #515

dunglas opened this issue Aug 9, 2024 · 1 comment · Fixed by #556
Labels
os/linux Things only for Linux OS

Comments

@dunglas
Copy link
Contributor

dunglas commented Aug 9, 2024

For improved security, what do you think about using by default the same flags as the Docker image? https://github.com/docker-library/php/blob/master/8.3/alpine3.20/zts/Dockerfile#L53-L55

@crazywhalecc crazywhalecc added question Further information is requested os/linux Things only for Linux OS labels Aug 9, 2024
@crazywhalecc
Copy link
Owner

It's useful to improve security, and now that the -fPIE flag is set, I think the only thing to consider is to keep -Os.

But I don't have a performance and security test plan at the moment, and these compilation parameters may also affect phpmicro. It would be better if there were more comprehensive tests on these flags.

@crazywhalecc crazywhalecc removed the question Further information is requested label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os/linux Things only for Linux OS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants