Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed scroll to top on content height change. #404

Merged
merged 1 commit into from
Oct 1, 2018

Conversation

amikot
Copy link
Contributor

@amikot amikot commented May 23, 2018

Now scroll position stays not changed when content height change.

Now scroll position stays not changed when content height change.
@craftpip
Copy link
Owner

craftpip commented Sep 4, 2018

I will have to look into this, Sometimes when content is changed inside it automatically scrolls down, and the user does not have an option to scroll up, that is why it was added as a workaround. Will work on this.

@craftpip craftpip merged commit 0eb97a2 into craftpip:master Oct 1, 2018
@FurkanGozukara
Copy link

FurkanGozukara commented May 14, 2020

still scrolls top and it breaks my buttons working since content height changes when you click a button that some some different css

how to fix this extremely annoying issue?

I have to prevent it auto scroll top how?

I will have to look into this, Sometimes when content is changed inside it automatically scrolls down, and the user does not have an option to scroll up, that is why it was added as a workaround. Will work on this.

@FurkanGozukara
Copy link

@amikot man you are a saver

I have removed this any now my problem solved

that.$contentPane.css({height:contentHeight}).scrollTop(0);

@craftpip this line is not removed in minified version. that is why i was having problem and wasted like 2 hours :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants