Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Discord is down the site crashes repeatedly #1668

Open
cozuya opened this issue Jul 18, 2020 · 2 comments
Open

If Discord is down the site crashes repeatedly #1668

cozuya opened this issue Jul 18, 2020 · 2 comments
Labels
bug Issues that report a bug help wanted Issues that require further help from contributors

Comments

@cozuya
Copy link
Owner

cozuya commented Jul 18, 2020

😑

My guess here is that there's an unhandled exception while using a https.request and or https.end. During the 1/2 hour Discord was down today I tried to find and fix (try catch) the ones I saw but wasn't successful. Not sure what is breaking here and may be a big pain to track down - the stack trace on production was unhelpful.

@cozuya cozuya added the bug Issues that report a bug label Jul 18, 2020
@Vigasaurus
Copy link
Collaborator

I have a strong hunch it's nothing on our end, but rather something in some dep, likely Passport from my minor poking.

@cozuya
Copy link
Owner Author

cozuya commented Jul 18, 2020

Feel free to close if this goes nowhere but ugh in my experience this seems like a miss on our part (though I never loved the try catch "solution" to similar problems we've had in the past). A real crashing error based off of a DNS failure in a npm package is a horrible experience. Could be wrong!

@Vigasaurus Vigasaurus added the help wanted Issues that require further help from contributors label Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that report a bug help wanted Issues that require further help from contributors
Projects
None yet
Development

No branches or pull requests

2 participants