Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/easy connect #2263

Merged
merged 7 commits into from
Mar 14, 2019
Merged

Fabo/easy connect #2263

merged 7 commits into from
Mar 14, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Mar 14, 2019

Adds guide on how to connect to local full node

Thank you! 🚀


For contributor:

  • Added entries in PENDING.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #2263 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2263   +/-   ##
========================================
  Coverage    96.68%   96.68%           
========================================
  Files          108      108           
  Lines         2321     2321           
  Branches       115      115           
========================================
  Hits          2244     2244           
  Misses          65       65           
  Partials        12       12

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #2263 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2263   +/-   ##
========================================
  Coverage    96.73%   96.73%           
========================================
  Files          106      106           
  Lines         2296     2296           
  Branches       116      116           
========================================
  Hits          2221     2221           
  Misses          63       63           
  Partials        12       12

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
PENDING.md Outdated Show resolved Hide resolved
jbibla
jbibla previously approved these changes Mar 14, 2019
fedekunze
fedekunze previously approved these changes Mar 14, 2019
@fedekunze fedekunze dismissed stale reviews from jbibla and themself via 7202ea4 March 14, 2019 13:04
@faboweb faboweb merged commit c9e7858 into develop Mar 14, 2019
@faboweb faboweb deleted the fabo/easy-connect branch March 14, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants