Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors at boot time #1934

Merged
merged 3 commits into from
Feb 8, 2019
Merged

Fix errors at boot time #1934

merged 3 commits into from
Feb 8, 2019

Conversation

sabau
Copy link
Contributor

@sabau sabau commented Feb 6, 2019

Description:
After running a yarn build:gaia from develop I encountred some errors

  • --moniker seems not to be a named parameter anymore
  • tls seems to be disabled by default instead of what the --help states

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

Signed-off-by: Karoly Albert Szabo <[email protected]>
@@ -53,7 +53,7 @@ async function initGenesis(
nodeHomeDir
) {
await makeExec(
`${nodeBinary} add-genesis-account ${address} 150stake,1000photino --home ${nodeHomeDir}`
`${nodeBinary} add-genesis-account ${address} 200000000stake,1000photino --home ${nodeHomeDir}`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤑

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

richness is gooood, but this change happened because of an error in the creation under 100000000stake

@jbibla
Copy link
Collaborator

jbibla commented Feb 6, 2019

from our develop or from SDK develop? can we confirm these are intended changes, not just bugs or mistakes?

@jbibla
Copy link
Collaborator

jbibla commented Feb 6, 2019

also, changelog 😄

@sabau sabau changed the title Fix errors at boot time [WIP] Fix errors at boot time Feb 6, 2019
@sabau
Copy link
Contributor Author

sabau commented Feb 6, 2019

From our develop, I removed the local-testnet folder and tried to build and start, then some errors occurred

…uential, remove unnecessary renaming

Signed-off-by: Karoly Albert Szabo <[email protected]>
@codecov
Copy link

codecov bot commented Feb 6, 2019

Codecov Report

Merging #1934 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1934   +/-   ##
=======================================
  Coverage     95.1%   95.1%           
=======================================
  Files          120     120           
  Lines         2593    2593           
  Branches       122     122           
=======================================
  Hits          2466    2466           
  Misses         117     117           
  Partials        10      10

@sabau
Copy link
Contributor Author

sabau commented Feb 6, 2019

The seed phrase was stripped recently as was printed in non standard way, I just created an issue to restore it cosmos/cosmos-sdk#3518

@sabau
Copy link
Contributor Author

sabau commented Feb 6, 2019

from our develop or from SDK develop? can we confirm these are intended changes, not just bugs or mistakes?

Yep, except the huge amount of stakes needed to boot. I shuould report also that one.

@sabau sabau changed the title [WIP] Fix errors at boot time Fix errors at boot time Feb 6, 2019
@jbibla jbibla merged commit 7d28027 into develop Feb 8, 2019
@sabau sabau deleted the sabau/fix-boot-process branch February 11, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants