fedekunze/1718 remove session pt 1 #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2019 14:19
2 tasks
jbibla
reviewed
Feb 8, 2019
Codecov Report
@@ Coverage Diff @@
## develop #1916 +/- ##
===========================================
+ Coverage 95.17% 95.51% +0.34%
===========================================
Files 121 121
Lines 2609 2611 +2
Branches 122 121 -1
===========================================
+ Hits 2483 2494 +11
+ Misses 116 108 -8
+ Partials 10 9 -1
|
added 3 commits
February 11, 2019 15:01
faboweb
reviewed
Feb 11, 2019
fedekunze
changed the title
fedekunze
changed the title
|
How do I test this? Screenshots would also be nice. |
@faboweb no changes are made to the UI here since you are still required to log in. So functionally it's the same as before. These are just changes required for the pt 2 PR (in which I will add the screenshots) |
2 tasks
fedekunze
changed the title
faboweb
reviewed
Feb 13, 2019
faboweb
reviewed
Feb 13, 2019
faboweb
reviewed
Feb 13, 2019
faboweb
reviewed
Feb 13, 2019
faboweb
reviewed
Feb 13, 2019
faboweb
reviewed
Feb 13, 2019
| state.externals.track(`pageview`, { | ||
| dl: `/session/welcome` | ||
| }) | ||
| state.externals.track(`pageview`, { dl: `/` }) |
There was a problem hiding this comment.
what is the thinking here?
There was a problem hiding this comment.
the main page is not longer /session/welcome
jbibla
reviewed
Feb 13, 2019
jbibla
reviewed
Feb 13, 2019
jbibla
reviewed
Feb 13, 2019
faboweb
reviewed
Feb 13, 2019
| @@ -1,6 +1,6 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
|
|
|||
| exports[`ActionModal has the expected html structure 1`] = ` | |||
| exports[`ActionModal has the expected html structure when user has logged in with ledger 1`] = ` | |||
There was a problem hiding this comment.
this still shows the password.
jbibla
reviewed
Feb 13, 2019
jbibla
reviewed
Feb 13, 2019
faboweb
reviewed
Feb 13, 2019
faboweb
reviewed
Feb 13, 2019
faboweb
reviewed
Feb 13, 2019
faboweb
reviewed
Feb 13, 2019
faboweb
reviewed
Feb 13, 2019
…mos/voyager into fedekunze/1718-explorer-mode fix conflict changelog
jbibla
reviewed
Feb 13, 2019
| proposalsurl="/governance" | ||
| slot="managed-body" | ||
| transaction="[object Object]" | ||
| unbondingtime="NaN" |
added 2 commits
February 13, 2019 14:51
…kunze/1718-explorer-mode
jbibla
approved these changes
Feb 13, 2019
This was referenced Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of #1718
Closes #1836
Closes #1918
Description:
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer