Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: align snapshots -> WEB #1850

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Fix: align snapshots -> WEB #1850

merged 2 commits into from
Jan 17, 2019

Conversation

sabau
Copy link
Contributor

@sabau sabau commented Jan 17, 2019

Description:

  • just align the snapshots to have working unit tests

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

Signed-off-by: Karoly Albert Szabo <[email protected]>
Signed-off-by: Karoly Albert Szabo <[email protected]>
@sabau sabau changed the title Fix: align snapshots Fix: align snapshots into WEB Jan 17, 2019
@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (web@0e11960). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             web    #1850   +/-   ##
======================================
  Coverage       ?   93.56%           
======================================
  Files          ?      116           
  Lines          ?     2517           
  Branches       ?      116           
======================================
  Hits           ?     2355           
  Misses         ?      153           
  Partials       ?        9

@sabau sabau changed the title Fix: align snapshots into WEB Fix: align snapshots -> WEB Jan 17, 2019
@faboweb faboweb merged commit 9d9462b into web Jan 17, 2019
@faboweb faboweb deleted the sabau/web/fix-snapshot-unit-test branch January 17, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants