Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve form styling, sizing, and error messaging #1754

Closed
jbibla opened this issue Dec 17, 2018 · 0 comments · Fixed by #1807
Closed

improve form styling, sizing, and error messaging #1754

jbibla opened this issue Dec 17, 2018 · 0 comments · Fixed by #1807
Assignees
Labels
design-work-needed 🎨 issues that require design work before development ux-improvement issues that would improve the user experience

Comments

@jbibla
Copy link
Collaborator

jbibla commented Dec 17, 2018

currently, including tooltips only when a button is disabled is not possible out of the box. the solution would be to either add a message for enabled buttons (which is redundant and would not be consistent with other buttons throughout the app) or duplicate buttons in the template to account for the various states (v-if for availableAtoms connected oldBondedAtoms etc...). my thinking has changed on this subject and i no longer thing that using tooltips for disabled buttons is the right thing to do.

since we have the new Connecting... value for buttons I think we should 1) leave all modal-triggering -buttons enabled and rely on proper form validation to communicate with the use and 2) disable form submission buttons unless a minimum amount of information is included (i think this is already the case).

i would like to close this ticket and open a new ticket to address proper form validation and error messages to continue the work @sabau completed in #1710.

this would mean that modal-triggering-buttons will only be disabled based on connected and form submit buttons would be enabled when a minimum amount of info is included. also, we need to display inline error messages on form elements and keep the modals open unless there is a successful submission.

@jbibla jbibla self-assigned this Dec 17, 2018
@faboweb faboweb added design-work-needed 🎨 issues that require design work before development ux-improvement issues that would improve the user experience labels Jan 15, 2019
@faboweb faboweb self-assigned this Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-work-needed 🎨 issues that require design work before development ux-improvement issues that would improve the user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants