Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create component for connecting, loading, loaded states #1688

Closed
faboweb opened this issue Dec 4, 2018 · 2 comments
Closed

Create component for connecting, loading, loaded states #1688

faboweb opened this issue Dec 4, 2018 · 2 comments
Labels

Comments

@faboweb
Copy link
Collaborator

faboweb commented Dec 4, 2018

We currently use tm-data-connecting, tm-data-loading, tm-data-msg in almost all views to handle connection states. We should refactor those 3 into one component.

@faboweb faboweb assigned jbibla and sabau and unassigned jbibla Dec 11, 2018
@sabau
Copy link
Contributor

sabau commented Dec 11, 2018

I'm unsure about the msg part, every message seems quite bounded to the single page, we can pass a tiny component as body of the message maybe.

Should we include also tm-data-error?

@jbibla
Copy link
Collaborator

jbibla commented Dec 12, 2018

we can pass a message as a prop.

yes, i think this component can cover all cases including errors if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants