Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display the unbonding tx in the "Unstaked Validators" list instead of the validator Li #1387

Closed
NodeGuy opened this issue Oct 1, 2018 · 5 comments

Comments

@NodeGuy
Copy link
Contributor

NodeGuy commented Oct 1, 2018

Split from #1364 (comment).

46092551-64d93d00-c1b5-11e8-8323-ea73b0505ba5

@sabau
Copy link
Contributor

sabau commented Dec 11, 2018

Just to be sure: should we fetch the transactions related to unbounding or it's enough to show the data coming from /stake/delegators/{addr}/unbonding_delegations

[
  {
    "balance": {
      "amount": "3",
      "denom": "steak"
    },
    "creation_height": "1379",
    "delegator_addr": "cosmos1ccwqds0dd6cxp44a7rpc6kscm7zj6jdcykaeut",
    "initial_balance": {
      "amount": "3",
      "denom": "steak"
    },
    "min_time": "2018-12-14T15:02:05.203889Z",
    "validator_addr": "cosmosvaloper1ccwqds0dd6cxp44a7rpc6kscm7zj6jdcpzfvsc"
  }
]

@faboweb faboweb removed the discuss label Dec 11, 2018
@faboweb
Copy link
Collaborator

faboweb commented Dec 11, 2018

Maybe also add redelegations as undelegations?

@sabau
Copy link
Contributor

sabau commented Dec 12, 2018

As for now it seems we can't have more than an unbounding transaction per validator: "existing unbonding delegation found"

@cwgoes if I understood you are on this right?

@cwgoes
Copy link

cwgoes commented Dec 12, 2018

If I understood you are on this right?

Yes. Working on some changes to fee distribution first but hopefully multiple unbonding delegations per validator should come long in a week or two - tracking issue here: cosmos/cosmos-sdk#1402

@fedekunze
Copy link
Contributor

The concept of the My Delegations is wrong here since we're showing the validators instead of the actual delegations/unbonds/redelegations.

Imo we should change here My Delegations for My Validators. The actual contents for the My Delegation should be the discussed on another issue based on the new unbonding and redelegation index implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants