Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console errors when running test #1379

Closed
6 of 7 tasks
jbibla opened this issue Sep 28, 2018 · 4 comments · Fixed by #1782
Closed
6 of 7 tasks

console errors when running test #1379

jbibla opened this issue Sep 28, 2018 · 4 comments · Fixed by #1782

Comments

@jbibla
Copy link
Collaborator

jbibla commented Sep 28, 2018

jest or yarn test will result in console errors which the CI ignores, but my git client doesn't like.

 PASS  test/unit/specs/store/node.spec.js
  ● Console

    console.log app/src/renderer/vuex/modules/notifications.js:34
      [ERROR] Error fetching validator set: Cannot read property 'validators'of undefined
    console.log app/src/renderer/vuex/modules/notifications.js:34
      [ERROR] Critical Error: Couldn't initialize the blockchain client. If the problem persists, please make an issue on GitHub.
 PASS  test/unit/specs/store/user.spec.js
  ● Console

    console.log app/src/renderer/vuex/modules/notifications.js:34
      [ERROR] Couldn't read keys: undefined
    console.log node_modules/raven-js/src/console.js:35
      [ERROR] Couldn't switch on error collection.: Error collection is disabled during development.
 PASS  test/unit/specs/components/wallet/PageSend.spec.js
  ● Console

    console.log app/src/renderer/vuex/modules/notifications.js:34
      [ERROR] Error Sending: An error occurred while trying to send: "Cannot read property 'amount' of undefined" 
PASS  test/unit/specs/components/common/TmSessionSignUp.spec.js
  ● Console

    console.log node_modules/raven-js/src/console.js:35
      [ERROR] Couldn't create account: test

 PASS  test/unit/specs/App.spec.js
  ● Console

    console.log app/src/renderer/vuex/modules/notifications.js:34
      [ERROR] Couldn't read keys: node.listKeys is not a function

 PASS  test/unit/specs/components/common/TmSessionSignIn.spec.js
  ● Console

    console.log app/src/renderer/vuex/modules/notifications.js:34
      [ERROR] Signing In Failed: undefined
 PASS  test/unit/specs/store/blockchain.spec.js
  ● Console

    console.log app/src/renderer/vuex/modules/notifications.js:34
      [ERROR] Couldn't query block: undefined

Fix errors in:

  • test/unit/specs/store/node.spec.js
  • test/unit/specs/store/user.spec.js
  • test/unit/specs/components/wallet/PageSend.spec.js
  • test/unit/specs/components/common/TmSessionSignUp.spec.js
  • test/unit/specs/components/common/TmSessionSignIn.spec.js
  • test/unit/specs/store/blockchain.spec.js
  • test/unit/specs/App.spec.js
@NodeGuy NodeGuy added the bug 🐛 issues related to unhandled errors in the code that need to be fixed label Sep 28, 2018
@faboweb
Copy link
Collaborator

faboweb commented Oct 1, 2018

Those are printed "errors" but in reality they are just console logs and shouldn't cause trouble. What does your git client say?

@faboweb
Copy link
Collaborator

faboweb commented Oct 8, 2018

@jbibla any feedback?

@jbibla
Copy link
Collaborator Author

jbibla commented Oct 9, 2018

i don't think they are effecting my git client. but should these be resolved?

@faboweb faboweb added discuss and removed bug 🐛 issues related to unhandled errors in the code that need to be fixed labels Oct 9, 2018
@faboweb
Copy link
Collaborator

faboweb commented Oct 9, 2018

Let's fix them one at a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants