From 9a045f9966101fa14d2082f0fdba9ffd0e63af52 Mon Sep 17 00:00:00 2001 From: Sean King Date: Thu, 25 Aug 2022 14:37:03 +0200 Subject: [PATCH 1/3] updating v3->v4 migration docs with fee middleware --- docs/migrations/v3-to-v4.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/migrations/v3-to-v4.md b/docs/migrations/v3-to-v4.md index 1526b1642e0..a9a0b7c8e07 100644 --- a/docs/migrations/v3-to-v4.md +++ b/docs/migrations/v3-to-v4.md @@ -18,6 +18,12 @@ No genesis or in-place migrations required when upgrading from v1 or v2 of ibc-g ## Chains +### Fee Middleware + +The Fee Middleware module, as the name suggests, plays the role of an IBC middleware and as such must be configured by chain developers to route and handle IBC messages correctly. + +Please read the Fee Middleware [integration documentation](https://ibc.cosmos.network/main/middleware/ics29-fee/overview.html) for an in depth guide on how to congfigure the module correctly in order to incentivize IBC packets. + ### Migration to fix support for base denoms with slashes As part of [v1.5.0](https://github.com/cosmos/ibc-go/releases/tag/v1.5.0), [v2.3.0](https://github.com/cosmos/ibc-go/releases/tag/v2.3.0) and [v3.1.0](https://github.com/cosmos/ibc-go/releases/tag/v3.1.0) some [migration handler code sample was documented](https://github.com/cosmos/ibc-go/blob/main/docs/migrations/support-denoms-with-slashes.md#upgrade-proposal) that needs to run in order to correct the trace information of coins transferred using ICS20 whose base denom contains slashes. @@ -125,6 +131,8 @@ if err := k.icaControllerKeeper.RegisterInterchainAccount(ctx, msg.ConnectionId, } ``` +In order to incentivize ICS27 packets using the fee middleware module a middleware stack that contains the fee middleware must be configured. Take a look at the following diff for an [example setup](https://github.com/cosmos/ibc-go/pull/1432/files#diff-d18972debee5e64f16e40807b2ae112ddbe609504a93ea5e1c80a5d489c3a08aL366). + ## Relayers When using the `DenomTrace` gRPC, the full IBC denomination with the `ibc/` prefix may now be passed in. From 14e674e61f1b7a54bb4b2194d2721f09dc608fc2 Mon Sep 17 00:00:00 2001 From: Sean King Date: Thu, 25 Aug 2022 14:40:50 +0200 Subject: [PATCH 2/3] fix: docs --- docs/migrations/v3-to-v4.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/migrations/v3-to-v4.md b/docs/migrations/v3-to-v4.md index a9a0b7c8e07..e03be3ec49c 100644 --- a/docs/migrations/v3-to-v4.md +++ b/docs/migrations/v3-to-v4.md @@ -22,7 +22,7 @@ No genesis or in-place migrations required when upgrading from v1 or v2 of ibc-g The Fee Middleware module, as the name suggests, plays the role of an IBC middleware and as such must be configured by chain developers to route and handle IBC messages correctly. -Please read the Fee Middleware [integration documentation](https://ibc.cosmos.network/main/middleware/ics29-fee/overview.html) for an in depth guide on how to congfigure the module correctly in order to incentivize IBC packets. +Please read the Fee Middleware [integration documentation](https://ibc.cosmos.network/main/middleware/ics29-fee/integration.html) for an in depth guide on how to congfigure the module correctly in order to incentivize IBC packets. ### Migration to fix support for base denoms with slashes From a4189df0dbe588275a772dd100f847e1be7baf66 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?colin=20axn=C3=A9r?= <25233464+colin-axner@users.noreply.github.com> Date: Wed, 21 Sep 2022 11:51:27 +0200 Subject: [PATCH 3/3] self requests --- docs/migrations/v3-to-v4.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/migrations/v3-to-v4.md b/docs/migrations/v3-to-v4.md index e03be3ec49c..b6ab165d066 100644 --- a/docs/migrations/v3-to-v4.md +++ b/docs/migrations/v3-to-v4.md @@ -24,6 +24,8 @@ The Fee Middleware module, as the name suggests, plays the role of an IBC middle Please read the Fee Middleware [integration documentation](https://ibc.cosmos.network/main/middleware/ics29-fee/integration.html) for an in depth guide on how to congfigure the module correctly in order to incentivize IBC packets. +Take a look at the following diff for an [example setup](https://github.com/cosmos/ibc-go/pull/1432/files#diff-d18972debee5e64f16e40807b2ae112ddbe609504a93ea5e1c80a5d489c3a08aL366) of how to incentivize ics27 channels. + ### Migration to fix support for base denoms with slashes As part of [v1.5.0](https://github.com/cosmos/ibc-go/releases/tag/v1.5.0), [v2.3.0](https://github.com/cosmos/ibc-go/releases/tag/v2.3.0) and [v3.1.0](https://github.com/cosmos/ibc-go/releases/tag/v3.1.0) some [migration handler code sample was documented](https://github.com/cosmos/ibc-go/blob/main/docs/migrations/support-denoms-with-slashes.md#upgrade-proposal) that needs to run in order to correct the trace information of coins transferred using ICS20 whose base denom contains slashes. @@ -131,8 +133,6 @@ if err := k.icaControllerKeeper.RegisterInterchainAccount(ctx, msg.ConnectionId, } ``` -In order to incentivize ICS27 packets using the fee middleware module a middleware stack that contains the fee middleware must be configured. Take a look at the following diff for an [example setup](https://github.com/cosmos/ibc-go/pull/1432/files#diff-d18972debee5e64f16e40807b2ae112ddbe609504a93ea5e1c80a5d489c3a08aL366). - ## Relayers When using the `DenomTrace` gRPC, the full IBC denomination with the `ibc/` prefix may now be passed in.