Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GetClientID from Misbehaviour interface #874

Closed
3 tasks
colin-axner opened this issue Feb 7, 2022 · 4 comments · Fixed by #897
Closed
3 tasks

Remove GetClientID from Misbehaviour interface #874

colin-axner opened this issue Feb 7, 2022 · 4 comments · Fixed by #897
Labels
02-client
Milestone
02-client refacto...

Comments

@colin-axner
Copy link
Contributor

Summary

Remove GetClientID from the Misbehaviour interface. It will always be supplied in conjunction with submitting misbehaviour. Needed to remove the Misbehaviour interface

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner mentioned this issue Feb 7, 2022
Closed
3 tasks
@colin-axner colin-axner moved this to Todo in ibc-go Feb 7, 2022
@notbdu notbdu mentioned this issue Feb 10, 2022
Merged
9 tasks
@colin-axner colin-axner moved this from Todo to In review in ibc-go Mar 8, 2022
@colin-axner
Copy link
Contributor Author

colin-axner commented Mar 9, 2022 •
edited
Loading

partially closed by #897

we should remove GetClientID from the misbehaviour in each light client implementation

@colin-axner
Copy link
Contributor Author

I'll do 07-tendermint

@colin-axner colin-axner mentioned this issue Mar 10, 2022
Merged
9 tasks
@damiannolan
Copy link
Member

I'll do 06-solomachine for this! :)

@damiannolan damiannolan mentioned this issue Mar 10, 2022
Merged
9 tasks
@seantking
Copy link
Contributor

Closing :)

Repository owner moved this from In review to Done in ibc-go Mar 11, 2022
@crodriguezvega crodriguezvega added this to the 02-client refactor milestone Mar 30, 2022
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
02-client
Projects
ibc-go
Status: Done 🥳
Milestone
02-client refactor alpha
Development

Successfully merging a pull request may close this issue.

chore: Remove GetClientID() From Misbehaviour Interface polymerdao/ibc-go
4 participants
@damiannolan @crodriguezvega @seantking @colin-axner