Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChanCloseInit Optimization in Fee Middleware #859

Closed
AdityaSripal opened this issue Feb 7, 2022 · 1 comment
Closed

ChanCloseInit Optimization in Fee Middleware #859

AdityaSripal opened this issue Feb 7, 2022 · 1 comment
Assignees
@colin-axner
Labels
29-fee
Milestone
Fee middleware beta

Comments

@AdityaSripal
Copy link
Member

Switch order in OnChanCloseInit to call application callback first as an optimization since it is likely a lot of applications may return an error

https://github.com/cosmos/ibc-go/blob/ics29-fee-middleware/modules/apps/29-fee/ibc_module.go#L150

This should not be taken up until discussion in #821 is resolved
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Feb 8, 2022
@colin-axner colin-axner self-assigned this Feb 28, 2022
@colin-axner colin-axner mentioned this issue Feb 28, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega added this to the Fee middleware beta milestone Mar 29, 2022
@crodriguezvega crodriguezvega moved this from Backlog to Todo in ibc-go Apr 4, 2022
@crodriguezvega
Copy link
Contributor

Closed by #1025.

Repository owner moved this from Todo to Done in ibc-go Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
Fee middleware beta
Development

No branches or pull requests
3 participants
@crodriguezvega @AdityaSripal @colin-axner