Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update app.go #772

Closed
4 tasks
seantking opened this issue Jan 19, 2022 · 2 comments
Closed
4 tasks

Update app.go #772

seantking opened this issue Jan 19, 2022 · 2 comments
Labels
29-fee good first issue Good for newcomers
Milestone
Fee middleware alpha

Comments

@seantking
Copy link
Contributor

seantking commented Jan 19, 2022 •
edited
Loading

Summary

Merge conflict likely caused bug. Update app.go.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@seantking seantking added this to the Fee Middleware milestone Jan 19, 2022
@seantking seantking changed the title Bug: Update app.gp Bug: Update app.go Jan 19, 2022
@seantking seantking added the good first issue Good for newcomers label Jan 19, 2022
@seantking seantking changed the title Bug: Update app.go Update app.go Jan 19, 2022
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Jan 20, 2022
@Rishirai7
Copy link

Its already updated

@colin-axner
Copy link
Contributor

No this is still an issue. It should be PortKeeper not FeeKeeper in the second argument. The comment above is incorrect

@seantking seantking mentioned this issue Jan 25, 2022
Merged
9 tasks
Repository owner moved this from Backlog to Done in ibc-go Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
29-fee good first issue Good for newcomers
Projects
ibc-go
Archived in project
Milestone
Fee middleware alpha
Development

No branches or pull requests
3 participants
@seantking @colin-axner @Rishirai7