Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inefficient construction of packet data in msg transfer #7080

Closed
3 tasks
colin-axner opened this issue Aug 7, 2024 · 0 comments
Closed
3 tasks

Inefficient construction of packet data in msg transfer #7080

colin-axner opened this issue Aug 7, 2024 · 0 comments
Assignees
@bznein
Labels
20-transfer feat: port-router type: performance Performance or storage optimizations
Milestone
05-port refactor ...

Comments

@colin-axner
Copy link
Contributor

Summary

After the quick refactor of MsgTransfer on the port router branch. I noticed we iterate over coins twice and create tokens from coin twice. In unwindHops and before sending a MsgSendPacket

We should refactor the code to pass unwindHops the tokens rather than coins so that we only iterate once

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added this to the 05-port refactor alpha milestone Aug 7, 2024
@colin-axner colin-axner added the type: performance Performance or storage optimizations label Aug 7, 2024
@colin-axner colin-axner moved this to Todo 🏃 in ibc-go Aug 7, 2024
@colin-axner colin-axner mentioned this issue Aug 7, 2024
Merged
10 tasks
@bznein bznein self-assigned this Aug 8, 2024
@bznein bznein mentioned this issue Aug 8, 2024
Merged
10 tasks
@bznein bznein closed this as completed Aug 8, 2024
@github-project-automation github-project-automation bot moved this from Todo 🏃 to Done 🥳 in ibc-go Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bznein bznein

Labels
20-transfer feat: port-router type: performance Performance or storage optimizations
Projects
ibc-go
Status: Done 🥳
Milestone
05-port refactor alpha
Development

No branches or pull requests
2 participants
@bznein @colin-axner