Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Router from IBCKeeper and use PortKeeper #6133

Closed
6 tasks
damiannolan opened this issue Apr 10, 2024 · 2 comments · Fixed by #6138
Closed
6 tasks

Remove Router from IBCKeeper and use PortKeeper #6133

damiannolan opened this issue Apr 10, 2024 · 2 comments · Fixed by #6138
Assignees
Labels
05-port Issues concerns the 05-port submodule core
Milestone

Comments

@damiannolan
Copy link
Member

damiannolan commented Apr 10, 2024

Summary

We currently maintain a reference to the IBC application router on the IBCKeeper as well as the PortKeeper submodule keeper.
This is often referred to as the "port router" as this is how we look up application callback stacks in order to route application handshake msgs and packet data to the appropriate handlers.

With moving towards a more consistent usage of standardising submodule keepers as reference types (see #6081) we should now be able to remove the Router reference from the IBCKeeper and instead rely directly on the one in PortKeeper.

With this change we can also probably make Router unexported within PortKeeper and add a Route() method on the PortKeeper instead, and all application callback stack access can flow through there.

  • Remove Router from IBCKeeper
  • Add GetRoute() types.IBCModule to PortKeeper
  • Replace usage of Router in core/keeper/msg_server.go with PortKeeper.Route()

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added core 05-port Issues concerns the 05-port submodule labels Apr 10, 2024
@damiannolan damiannolan added this to the v9.0.0 milestone Apr 10, 2024
@damiannolan damiannolan moved this to Todo 🏃 in ibc-go Apr 10, 2024
@bznein
Copy link
Contributor

bznein commented Apr 10, 2024

@damiannolan I wouldn't mind taking this one :)

@chatton
Copy link
Contributor

chatton commented Apr 10, 2024

go for it @bznein this one depends on #6081 to me merged first

@crodriguezvega crodriguezvega moved this from Todo 🏃 to In progress 👷 in ibc-go Apr 10, 2024
@github-project-automation github-project-automation bot moved this from In progress 👷 to Done 🥳 in ibc-go Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05-port Issues concerns the 05-port submodule core
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

3 participants