You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently maintain a reference to the IBC application router on the IBCKeeper as well as the PortKeeper submodule keeper.
This is often referred to as the "port router" as this is how we look up application callback stacks in order to route application handshake msgs and packet data to the appropriate handlers.
With moving towards a more consistent usage of standardising submodule keepers as reference types (see #6081) we should now be able to remove the Router reference from the IBCKeeper and instead rely directly on the one in PortKeeper.
With this change we can also probably make Router unexported within PortKeeper and add a Route() method on the PortKeeper instead, and all application callback stack access can flow through there.
Remove Router from IBCKeeper
Add GetRoute() types.IBCModule to PortKeeper
Replace usage of Router in core/keeper/msg_server.go with PortKeeper.Route()
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged/assigned
The text was updated successfully, but these errors were encountered:
Summary
We currently maintain a reference to the IBC application router on the
IBCKeeper
as well as thePortKeeper
submodule keeper.This is often referred to as the "port router" as this is how we look up application callback stacks in order to route application handshake msgs and packet data to the appropriate handlers.
With moving towards a more consistent usage of standardising submodule keepers as reference types (see #6081) we should now be able to remove the
Router
reference from theIBCKeeper
and instead rely directly on the one inPortKeeper
.With this change we can also probably make
Router
unexported withinPortKeeper
and add aRoute()
method on thePortKeeper
instead, and all application callback stack access can flow through there.Router
fromIBCKeeper
GetRoute() types.IBCModule
toPortKeeper
Router
incore/keeper/msg_server.go
withPortKeeper.Route()
For Admin Use
The text was updated successfully, but these errors were encountered: