-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move client state testing to light client module entry points #6001
Closed
2 of 7 tasks
Labels
testing
Testing package and unit/integration tests
type: code hygiene
Clean up code but without changing functionality or interfaces
type: refactor
Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
Comments
damiannolan
added
testing
Testing package and unit/integration tests
type: code hygiene
Clean up code but without changing functionality or interfaces
type: refactor
Architecture, code or CI improvements that may or may not tackle technical debt.
labels
Mar 14, 2024
10 tasks
I am working on the 06-solomachine tests. |
small conflict here, had picked it up yesterday night, synced up async. Picking up solomachine and at least 08-wasm myself atm. |
This was referenced Mar 21, 2024
This was referenced Mar 22, 2024
10 tasks
think we should just close issue with charly's PR for tendermint and leave a comment on #5959 for localhost tests. |
10 tasks
10 tasks
10 tasks
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
testing
Testing package and unit/integration tests
type: code hygiene
Clean up code but without changing functionality or interfaces
type: refactor
Architecture, code or CI improvements that may or may not tackle technical debt.
Summary
#5806 introduced the light client module interface and its associated implementations within ibc-go.
We should migrate unit tests to use the entrypoints for methods on the light client module. This should increase code coverage.
This can be broken into separate PRs for each client module. Existing tests should be refactored to use the
expError error
pattern in favour ofexpPass bool
For Admin Use
The text was updated successfully, but these errors were encountered: