Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codec type registration tests #4747

Closed
11 tasks done
damiannolan opened this issue Sep 21, 2023 · 1 comment · Fixed by #4853
Closed
11 tasks done

Add codec type registration tests #4747

damiannolan opened this issue Sep 21, 2023 · 1 comment · Fixed by #4853
Assignees
@damiannolan
Labels
good first issue Good for newcomers testing Testing package and unit/integration tests

Comments

@damiannolan
Copy link
Member

damiannolan commented Sep 21, 2023 •
edited by DimitrisJim
Loading

Add codec type registration tests for each ibc app and core submodule.

  • 02-client
  • 03-connection
  • 04-channel
  • 23-commitment
  • 06-solomachine
  • 07-tendermint
  • 09-localhost
  • transfer
  • 29-fee
  • 27-interchain-accounts
  • 08-wasm (use feat/wasm-clients)

We should replicate this testing to each codec.go of our apps and submodules.

See the provided pull request as an reference example:

ref: #4746
@damiannolan damiannolan added good first issue Good for newcomers testing Testing package and unit/integration tests labels Sep 21, 2023
@damiannolan damiannolan moved this to Todo in ibc-go Sep 21, 2023
@damiannolan damiannolan mentioned this issue Sep 21, 2023
Merged
9 tasks
@damiannolan damiannolan self-assigned this Sep 25, 2023
@damiannolan damiannolan moved this from Todo to In progress in ibc-go Sep 25, 2023
@damiannolan damiannolan mentioned this issue Sep 25, 2023
Merged
9 tasks
@DimitrisJim
Copy link
Contributor

DimitrisJim commented Sep 25, 2023 •
edited
Loading

note for 08-wasm, we could use InterfaceRegistry on TestEncodingConfig directly since Codec doesn't have the function to get it (on 0.47.5).

edit: best to leave it until 08-wasm has been brought up to use sdk 0.50. sdk's MsgTypeURL expects an sdk.Msg in 0.47.5 which ClientState and the like don't implement. (In 0.50, this has been changed to expect a proto.Message).

@DimitrisJim DimitrisJim mentioned this issue Sep 27, 2023
Merged
9 tasks
@DimitrisJim DimitrisJim mentioned this issue Oct 9, 2023
Merged
9 tasks
@DimitrisJim DimitrisJim linked a pull request Oct 9, 2023 that will close this issue
Add test for types registered in 08-wasm. #4853
Merged
9 tasks
@github-project-automation github-project-automation bot moved this from In progress to Done in ibc-go Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
good first issue Good for newcomers testing Testing package and unit/integration tests
Projects
ibc-go
Status: Done 🥳
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test for types registered in 08-wasm. cosmos/ibc-go
2 participants
@damiannolan @DimitrisJim