You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Implement the channel upgrade callback handlers for transfer.
Separate PRs can be opened for each callback handler including tests.
The implementation should ensure that the upgrade parameters are compatible with the transfer app.
This includes ordering enforced in ValidateTransferChannelParams as well as version checking, i.e. the upgrade version must be ics20-1.
OnChanUpgradeInit
OnChanUpgradeTry
OnChanUpgradeAck
OnChanUpgradeOpen
OnChanUpgradeRestore
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged/assigned
The text was updated successfully, but these errors were encountered:
Upgrade fields are validated in INIT, TRY and ACK. Now that fields are added to OnChanUpgradeOpen I don't see why we would need to do any extra validation on them. Also, the OnChanUpgradeOpen callback does not have an error return.
Do you think its fine to no-op on OnChanUpgradeOpen in transfer? @colin-axner
Closing this as I think all handlers are more or less completed for channel upgradability in transfer. There is working integration test with fee middleware in #4533.
Summary
Implement the channel upgrade callback handlers for
transfer
.Separate PRs can be opened for each callback handler including tests.
The implementation should ensure that the upgrade parameters are compatible with the transfer app.
This includes ordering enforced in
ValidateTransferChannelParams
as well as version checking, i.e. the upgrade version must beics20-1
.OnChanUpgradeInit
OnChanUpgradeTry
OnChanUpgradeAck
OnChanUpgradeOpen
OnChanUpgradeRestore
For Admin Use
The text was updated successfully, but these errors were encountered: