Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sdk.MustSortJSON from channel types Acknowledgement #3920

Closed
3 tasks
Tracked by #3916
colin-axner opened this issue Jun 21, 2023 · 1 comment · Fixed by #5377
Closed
3 tasks
Tracked by #3916

Remove sdk.MustSortJSON from channel types Acknowledgement #3920

colin-axner opened this issue Jun 21, 2023 · 1 comment · Fixed by #5377
Labels
04-channel help wanted Issues for which we would appreciate help/support from the community type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@colin-axner
Copy link
Contributor

Summary

Same reasoning as #3915, the sorting order should not change cross compatibility


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added type: code hygiene Clean up code but without changing functionality or interfaces 04-channel labels Jun 21, 2023
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Nov 14, 2023
@crodriguezvega crodriguezvega added the help wanted Issues for which we would appreciate help/support from the community label Nov 14, 2023
@expertdicer
Copy link
Contributor

I don't think we can use standard encoding/json lib because the proto of Acknowledgement contains enum

message Acknowledgement {
  // response contains either a result or an error and must be non-empty
  oneof response {
    bytes  result = 21;
    string error  = 22;
  }
}

@github-project-automation github-project-automation bot moved this from Backlog to Done in ibc-go Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
04-channel help wanted Issues for which we would appreciate help/support from the community type: code hygiene Clean up code but without changing functionality or interfaces
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

3 participants