Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sdk.MustSortJSON from interchain account packet data GetBytes function #3917

Closed
3 tasks
Tracked by #3916
colin-axner opened this issue Jun 21, 2023 · 0 comments · Fixed by #5379
Closed
3 tasks
Tracked by #3916

Remove sdk.MustSortJSON from interchain account packet data GetBytes function #3917

colin-axner opened this issue Jun 21, 2023 · 0 comments · Fixed by #5379
Labels
type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@colin-axner
Copy link
Contributor

Summary

See reasoning in #3915. Do not switch to standard json library as this changes the json econding due to the use of the enum on the Type field.

Problem Definition

Sorting is unnecessary and has been deprecated in the SDK.

We cannot change to standard json because the encoding is different:

json

{"type":1,"data":"ZGF0YQ==","memo":"memo"}

proto3 json

{"type":"TYPE_EXECUTE_TX","data":"ZGF0YQ==","memo":"memo"}

NOTE: proto3 json can decode the standard json encoding, but the standard json library cannot decode the proto3 json encoding

Proposal

Remove sdk.MustSortJSON usage in InterchainAccountPacketData.GetBytes()


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the type: code hygiene Clean up code but without changing functionality or interfaces label Jun 21, 2023
@expertdicer expertdicer mentioned this issue Dec 12, 2023
9 tasks
@github-project-automation github-project-automation bot moved this to Done in ibc-go Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code hygiene Clean up code but without changing functionality or interfaces
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

1 participant