Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INIT Handshake Msgs emit unnecessary event attribute #3847

Closed
AdityaSripal opened this issue Jun 14, 2023 · 3 comments · Fixed by #3867
Closed

INIT Handshake Msgs emit unnecessary event attribute #3847

AdityaSripal opened this issue Jun 14, 2023 · 3 comments · Fixed by #3867
Assignees
@ruthishvitwit
Labels
good first issue Good for newcomers

Comments

@AdityaSripal
Copy link
Member

Both ConnOpenInit and ChanOpenInit emit the counterparty connection/channel id even though they will both be empty in this stage. This can be removed (or deprecated and then removed)

https://github.com/cosmos/ibc-go/blob/main/modules/core/04-channel/keeper/events.go#L21

https://github.com/cosmos/ibc-go/blob/main/modules/core/03-connection/keeper/events.go#L17
@AdityaSripal AdityaSripal added type: code hygiene Clean up code but without changing functionality or interfaces good first issue Good for newcomers and removed type: code hygiene Clean up code but without changing functionality or interfaces labels Jun 14, 2023
@ruthishvitwit
Copy link
Contributor

@AdityaSripal can i work on this issue??

@ruthishvitwit ruthishvitwit mentioned this issue Jun 16, 2023
Merged
9 tasks
@ruthishvitwit
Copy link
Contributor

ruthishvitwit commented Jun 16, 2023 •
edited
Loading

I have tried to do what i could understand from the above given description. Can u give me a deeper insight if furthur changes are required??

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Jun 16, 2023 •
edited
Loading

It makes sense to see how the relayers use this, if they do. Deprecation would make more sense if removing this would cause their api to break (though I doubt it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruthishvitwit ruthishvitwit

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary event attribute from INIT Handshake Msgs ruthishvitwit/ibc-go
3 participants
@DimitrisJim @AdityaSripal @ruthishvitwit