-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to send localhost ibc transfer #3568
Comments
Thank you for reporting this error, @jtieri. We will look into it, but I just wanted to share that we have an e2e test that makes an ICS20 transfer over the localhost client and it has been passing for us. The test doesn't use the golang relayer though; we broadcast all the handshake messages manually. But maybe we could do a bit of quick refactoring and plugin the relayer if you have a tag that we can use? |
Hey @jtieri, I spent some time looking into this today. It looks like it was due to this I modified the cmd to use something like this: simd tx ibc-transfer transfer transfer channel-0 cosmos1t5u0jfg3ljsjrh2m9e47d4ny2hea7eehxrzdgd 1000stake --from faucet --home /var/cosmos-chain/simd --chain-id chain-a --keyring-backend test --absolute-timeouts --packet-timeout-timestamp 9999999999999999999 And following that I can see a packet commitment in state: root@chain-a-val-0-TestLocalhostIBC:/# simd q ibc channel packet-commitments transfer channel-0
commitments:
- channel_id: channel-0
data: Dn0itB74YSMoUjShG/YuFfgVSIWUcFbKgEC1E8XKFQs=
port_id: transfer
sequence: "1"
height:
revision_height: "794"
revision_number: "0"
pagination:
next_key: null
total: "0" I think we'll need to adapt the transfer CLI to accommodate the localhost client, as it doesn't use consensus states. |
Oh interesting. The error happens before the I just created a branch on GH and there should be an accompanying Docker image now here |
Ooops ignore my previous response, I typed up a reply and sent it without refreshing the page haha Ahh thanks so much @damiannolan!! 🙏 |
Nice! We have an issue (#3197) to pull in a relayer tag for e2e tests so we can pick that up soon |
Awesome, I just confirmed that with your suggestions localhost ics-20 transfers are working with the relayer. |
Summary of Bug
We got localhost channel handshakes working with the go-relayer and I started to test ics-20 transfers but the cmd to initiate the transfer fails every time.
The cmd being executed:
Error logs:
I'm using the ibc-go-simd docker image from GHCR built from the main branch.
Looks like the error is returned from here:
ibc-go/modules/core/04-channel/keeper/packet.go
Lines 68 to 71 in 8571b04
Expected Behaviour
Version
89ecf25
Steps to Reproduce
I have prepared a test case in the relayer repo here:
https://github.com/cosmos/relayer/blob/fb9b953cbc81e6c01774c719adbe35f220f809f8/interchaintest/localhost_client_test.go#L21
For Admin Use
The text was updated successfully, but these errors were encountered: