Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for config file for running e2e tests #3254

Closed
3 tasks
chatton opened this issue Mar 8, 2023 · 0 comments · Fixed by #3260
Closed
3 tasks

Add support for config file for running e2e tests #3254

chatton opened this issue Mar 8, 2023 · 0 comments · Fixed by #3260
Assignees
Labels
e2e type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.

Comments

@chatton
Copy link
Contributor

chatton commented Mar 8, 2023

Problem Definition

Our current e2e tests rely solely on environment. variables for configuration. This is fine when there are relatively few variables, but as our tests have gotten more involved, there have been more and more configuration options being added.

Proposal

Add file that enables granular configuration over test settings.

Here is an example for what this might look like

{
   "chains":[
      {
         "chainId":"chain-a",
         "numValidators":4,
         "numFullNodes":1,
         "image":"ghcr.io/cosmos/ibc-go-simd",
         "tag":"main",
         "binary":"simd"
      },
      {
         "chainId":"chain-b",
         "numValidators":4,
         "numFullNodes":1,
         "image":"ghcr.io/cosmos/ibc-go-simd",
         "tag":"main",
         "binary":"simd"
      }
   ],
   "relayer":{
      "type":"rly",
      "image":"ghcr.io/cosmos/relayer",
      "tag":"main"
   },

   "upgrade": {
       "planName": "normal upgrade",
       "tag": "v7.0.0-rc0"
    }
}

We can allow the environment variables to take precedence so we don't need to modify our CI immediately.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@chatton chatton added type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. e2e labels Mar 8, 2023
@chatton chatton self-assigned this Mar 8, 2023
@crodriguezvega crodriguezvega moved this to In review in ibc-go Mar 20, 2023
@github-project-automation github-project-automation bot moved this from In review to Todo in ibc-go Mar 21, 2023
@chatton chatton moved this from Todo to Done in ibc-go Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant