Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: migrate to cometbft v0.37 #3175

Merged
merged 18 commits into from
Mar 6, 2023
Merged

Conversation

crodriguezvega
Copy link
Contributor

@crodriguezvega crodriguezvega commented Feb 20, 2023

Description

Updating to tip of Cosmos SDK release/v0.47.x. This is still very much work in progress.
I will update the branch with the next SDK v0.47 RC when available.

Updated to SDK v0.47-rc3 and CometBFT v0.37-rc3.

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@crodriguezvega
Copy link
Contributor Author

I am not sure what to do with the import paths in proto/ibc/lightclients/tendermint/v1/tendermint.proto...

crodriguezvega and others added 10 commits February 23, 2023 15:59
# Conflicts:
#	modules/apps/27-interchain-accounts/controller/keeper/keeper.go
#	modules/apps/transfer/keeper/mbt_relay_test.go
#	modules/apps/transfer/types/trace.go
#	modules/core/02-client/client/utils/utils.go
#	modules/core/02-client/keeper/keeper.go
#	modules/core/03-connection/keeper/keeper.go
#	modules/core/04-channel/types/acknowledgement_test.go
#	modules/core/23-commitment/types/merkle.go
#	modules/core/23-commitment/types/utils.go
#	modules/light-clients/07-tendermint/client_state.go
#	modules/light-clients/07-tendermint/consensus_state.go
#	modules/light-clients/07-tendermint/header.go
#	modules/light-clients/07-tendermint/misbehaviour.go
#	modules/light-clients/07-tendermint/misbehaviour_handle.go
#	modules/light-clients/07-tendermint/update.go
#	testing/chain.go
# Conflicts:
#	e2e/go.mod
#	e2e/go.sum
#	go.mod
#	go.sum
@crodriguezvega crodriguezvega changed the title deps(wip): update to cometbft v0.37 deps: migrate to cometbft v0.37 Mar 5, 2023
@crodriguezvega crodriguezvega marked this pull request as ready for review March 5, 2023 22:00
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work everyone!

github.com/sasha-s/go-deadlock v0.3.1 // indirect
github.com/spf13/afero v1.9.3 // indirect
github.com/spf13/jwalterweatherman v1.1.0 // indirect
github.com/spf13/pflag v1.0.5 // indirect
github.com/subosito/gotenv v1.4.2 // indirect
github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7 // indirect
github.com/syndtr/goleveldb v1.0.1-0.20220721030215-126854af5e6d // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder where this indirect is coming from

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

randomly wondered this too (due to seeing the replace), its cometbft-db pulling it in.

@colin-axner colin-axner merged commit 143e5d8 into main Mar 6, 2023
@colin-axner colin-axner deleted the carlos/update-cometbft-v0.37 branch March 6, 2023 15:33
mergify bot pushed a commit that referenced this pull request Mar 6, 2023
(cherry picked from commit 143e5d8)

# Conflicts:
#	docs/dev/go-style-guide.md
#	e2e/go.mod
#	e2e/go.sum
#	e2e/semverutil/semver.go
#	e2e/testconfig/testconfig.go
#	go.mod
#	go.sum
#	modules/apps/27-interchain-accounts/controller/keeper/keeper.go
#	modules/apps/transfer/keeper/mbt_relay_test.go
#	modules/apps/transfer/types/trace.go
#	modules/core/02-client/client/utils/utils.go
#	modules/core/02-client/keeper/keeper.go
#	modules/core/03-connection/keeper/keeper.go
#	modules/core/04-channel/types/acknowledgement_test.go
#	modules/core/23-commitment/types/merkle.go
#	modules/core/23-commitment/types/utils.go
#	modules/light-clients/07-tendermint/client_state.go
#	modules/light-clients/07-tendermint/consensus_state.go
#	modules/light-clients/07-tendermint/header.go
#	modules/light-clients/07-tendermint/misbehaviour.go
#	modules/light-clients/07-tendermint/misbehaviour_handle.go
#	modules/light-clients/07-tendermint/update.go
#	testing/README.md
#	testing/chain.go
mergify bot pushed a commit that referenced this pull request Mar 6, 2023
(cherry picked from commit 143e5d8)

# Conflicts:
#	docs/dev/go-style-guide.md
#	e2e/go.mod
#	e2e/go.sum
#	e2e/semverutil/semver.go
#	e2e/testconfig/testconfig.go
#	go.mod
#	go.sum
#	modules/apps/27-interchain-accounts/controller/keeper/keeper.go
#	modules/apps/transfer/keeper/mbt_relay_test.go
#	modules/apps/transfer/types/trace.go
#	modules/core/02-client/client/utils/utils.go
#	modules/core/02-client/keeper/keeper.go
#	modules/core/03-connection/keeper/keeper.go
#	modules/core/04-channel/types/acknowledgement_test.go
#	modules/core/23-commitment/types/merkle.go
#	modules/core/23-commitment/types/utils.go
#	modules/light-clients/07-tendermint/client_state.go
#	modules/light-clients/07-tendermint/consensus_state.go
#	modules/light-clients/07-tendermint/header.go
#	modules/light-clients/07-tendermint/misbehaviour.go
#	modules/light-clients/07-tendermint/misbehaviour_handle.go
#	modules/light-clients/07-tendermint/update.go
#	testing/README.md
#	testing/chain.go
colin-axner added a commit that referenced this pull request Mar 7, 2023
* deps: migrate to cometbft v0.37 (#3175)

(cherry picked from commit 143e5d8)

# Conflicts:
#	docs/dev/go-style-guide.md
#	e2e/go.mod
#	e2e/go.sum
#	e2e/semverutil/semver.go
#	e2e/testconfig/testconfig.go
#	go.mod
#	go.sum
#	modules/apps/27-interchain-accounts/controller/keeper/keeper.go
#	modules/apps/transfer/keeper/mbt_relay_test.go
#	modules/apps/transfer/types/trace.go
#	modules/core/02-client/client/utils/utils.go
#	modules/core/02-client/keeper/keeper.go
#	modules/core/03-connection/keeper/keeper.go
#	modules/core/04-channel/types/acknowledgement_test.go
#	modules/core/23-commitment/types/merkle.go
#	modules/core/23-commitment/types/utils.go
#	modules/light-clients/07-tendermint/client_state.go
#	modules/light-clients/07-tendermint/consensus_state.go
#	modules/light-clients/07-tendermint/header.go
#	modules/light-clients/07-tendermint/misbehaviour.go
#	modules/light-clients/07-tendermint/misbehaviour_handle.go
#	modules/light-clients/07-tendermint/update.go
#	testing/README.md
#	testing/chain.go

* remove e2e directory

* chore: fix merge conflicts

* fix: indentation

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Colin Axnér <[email protected]>
colin-axner added a commit that referenced this pull request Mar 7, 2023
* deps: migrate to cometbft v0.37 (#3175)

(cherry picked from commit 143e5d8)

# Conflicts:
#	docs/dev/go-style-guide.md
#	e2e/go.mod
#	e2e/go.sum
#	e2e/semverutil/semver.go
#	e2e/testconfig/testconfig.go
#	go.mod
#	go.sum
#	modules/apps/27-interchain-accounts/controller/keeper/keeper.go
#	modules/apps/transfer/keeper/mbt_relay_test.go
#	modules/apps/transfer/types/trace.go
#	modules/core/02-client/client/utils/utils.go
#	modules/core/02-client/keeper/keeper.go
#	modules/core/03-connection/keeper/keeper.go
#	modules/core/04-channel/types/acknowledgement_test.go
#	modules/core/23-commitment/types/merkle.go
#	modules/core/23-commitment/types/utils.go
#	modules/light-clients/07-tendermint/client_state.go
#	modules/light-clients/07-tendermint/consensus_state.go
#	modules/light-clients/07-tendermint/header.go
#	modules/light-clients/07-tendermint/misbehaviour.go
#	modules/light-clients/07-tendermint/misbehaviour_handle.go
#	modules/light-clients/07-tendermint/update.go
#	testing/README.md
#	testing/chain.go

* remove e2e directory

* chore: fix merge conflicts

* fix: indentation

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: Colin Axnér <[email protected]>
@faddat faddat mentioned this pull request Jun 23, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants