Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate error packages #2896

Closed
3 tasks
tac0turtle opened this issue Dec 7, 2022 · 1 comment · Fixed by #3186
Closed
3 tasks

migrate error packages #2896

tac0turtle opened this issue Dec 7, 2022 · 1 comment · Fixed by #3186
Assignees
Milestone

Comments

@tac0turtle
Copy link
Member

Summary

Cosmos SDK has spun out the errors package into its own go.mod in light of the recent conversation on reducing dependency on the sdk, ibc-go should be migrated to cosmossdk.io/errors to take advantage of this.

We did not move the default error types over cause the idea is that users/app devs will create their own with their custom codespace.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Jan 23, 2023
@chatton chatton assigned chatton and unassigned chatton Jan 23, 2023
@damiannolan
Copy link
Member

We did not move the default error types over cause the idea is that users/app devs will create their own with their custom codespace.

Should ibc-go not be using the default types from the sdk root codespace then, such as ErrInvalidCoins, ErrInvalidAddress etc?

@crodriguezvega crodriguezvega added this to the v7.1.0 milestone Feb 20, 2023
@chatton chatton self-assigned this Feb 21, 2023
@damiannolan damiannolan moved this from Todo to In progress in ibc-go Feb 21, 2023
@github-project-automation github-project-automation bot moved this from In progress to Todo in ibc-go Feb 27, 2023
@damiannolan damiannolan moved this from Todo to Done in ibc-go Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants