Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow optimistic sends #2670

Closed
2 of 3 tasks
crodriguezvega opened this issue Nov 3, 2022 · 0 comments · Fixed by #3009
Closed
2 of 3 tasks

Disallow optimistic sends #2670

crodriguezvega opened this issue Nov 3, 2022 · 0 comments · Fixed by #3009
Assignees
@charleenfei
Labels
04-channel change: state machine breaking Issues or PRs that break consensus (need to be released in at least a new minor version) help wanted Issues for which we would appreciate help/support from the community type: bug Something isn't working as expected
Milestone
v7.0.0

Comments

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Nov 3, 2022 •
edited
Loading

Problem

Optimistic sends are not fully functional since a packet that is sent on a channel that would not eventually open cannot be timed out.

Solution

To prevent that this situation happens and affects users we should not allow optimistic sends for now until we can properly support them. This problem actually already affected a user in the past.

Proposal

  • Change this check to channel.State != types.OPEN so that packets can only be sent when the channel is open.
  • Adapt any necessary tests.

This is a state-machine breaking change. We can discuss whether to do minor back ports or not.

cc: @AdityaSripal

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega added type: bug Something isn't working as expected 04-channel labels Nov 3, 2022
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Nov 3, 2022
@crodriguezvega crodriguezvega added change: state machine breaking Issues or PRs that break consensus (need to be released in at least a new minor version) help wanted Issues for which we would appreciate help/support from the community labels Nov 3, 2022
@crodriguezvega crodriguezvega moved this from Backlog to Todo in ibc-go Dec 19, 2022
@crodriguezvega crodriguezvega added this to the v7.0.0 milestone Jan 8, 2023
@charleenfei charleenfei self-assigned this Jan 11, 2023
@charleenfei charleenfei moved this from Todo to In progress in ibc-go Jan 13, 2023
@charleenfei charleenfei mentioned this issue Jan 13, 2023
Merged
9 tasks
@charleenfei charleenfei moved this from In progress to In review in ibc-go Jan 13, 2023
@github-project-automation github-project-automation bot moved this from In review to Todo in ibc-go Jan 18, 2023
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Jan 22, 2023
@crodriguezvega crodriguezvega mentioned this issue May 17, 2023
Open
@bluele bluele mentioned this issue Nov 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charleenfei charleenfei

Labels
04-channel change: state machine breaking Issues or PRs that break consensus (need to be released in at least a new minor version) help wanted Issues for which we would appreciate help/support from the community type: bug Something isn't working as expected
Projects
ibc-go
Status: Done 🥳
Milestone
v7.0.0
Development

Successfully merging a pull request may close this issue.

fix: change check to disallow optimistic sends cosmos/ibc-go
2 participants
@crodriguezvega @charleenfei