Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use smaller number of validators when running tests locally #2667

Closed
3 tasks
chatton opened this issue Nov 3, 2022 · 2 comments
Closed
3 tasks

Use smaller number of validators when running tests locally #2667

chatton opened this issue Nov 3, 2022 · 2 comments
Labels

Comments

@chatton
Copy link
Contributor

chatton commented Nov 3, 2022

Summary

Currently, we have hard coded values for validators to run in our tests.

These numbers are good for CI, but when iterating on tests locally can be pain unless manually changed to a lower number. We can lower these to 1, 0 for example when not running in CI.

in github actions, a CI=true environment variable is set, we could leverage this existing value to conditionally set these values.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@chatton chatton added the e2e label Nov 3, 2022
@expertdicer
Copy link
Contributor

I think this should be closed as I saw that someone already do this

@DimitrisJim
Copy link
Contributor

DimitrisJim commented May 19, 2023

I think this should be closed as I saw that someone already do this

Nice find! This was indeed addressed in aabb07a of #3079:

// getValidatorsAndFullNodes returns the number of validators and full nodes respectively that should be used for
// the test. If the test is running in CI, more nodes are used, when running locally a single node is used to
// use less resources and allow the tests to run faster.
func getValidatorsAndFullNodes() (int, int) {
if testconfig.IsCI() {
return 4, 1
}
return 1, 0
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants