Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all "TypeMsg.." constants #2434

Closed
3 tasks
colin-axner opened this issue Sep 29, 2022 · 3 comments · Fixed by #2478
Closed
3 tasks

Remove all "TypeMsg.." constants #2434

colin-axner opened this issue Sep 29, 2022 · 3 comments · Fixed by #2478
Assignees
Labels
type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@colin-axner
Copy link
Contributor

Summary

Throughout the codebase we have "TypeMsg..." constants such as:

  • TypeMsgTransfer
  • TypeMsgCreateClient
  • etc

These should be removed

Problem Definition

These constants are a relic of previous SDK functionality which used a string returned from a "Type()" function to route messages internally. The SDK now uses gRPC and thus the proto url to route messages. These constants should be unused and have no intended meaning at the moment

Proposal

Remove all "TypeMsg..." constants. If they are being used somewhere, replace with appropriate usage


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the type: code hygiene Clean up code but without changing functionality or interfaces label Sep 29, 2022
@crodriguezvega
Copy link
Contributor

crodriguezvega commented Oct 4, 2022

@colin-axner is it ok then that we remove the implementations of the Type() functions that are remaining (like here for transfer?

@alizahidraja
Copy link
Contributor

Lmk if I can work on this 👋

@crodriguezvega
Copy link
Contributor

Yes, thank you, @alizahidraja!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants