Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify MsgSendTx fields #2232

Closed
3 tasks
colin-axner opened this issue Sep 8, 2022 · 0 comments · Fixed by #2280
Closed
3 tasks

Modify MsgSendTx fields #2232

colin-axner opened this issue Sep 8, 2022 · 0 comments · Fixed by #2280
Assignees
@chatton
Labels
27-interchain-accounts
Milestone
v6.0.0

Comments

@colin-axner
Copy link
Contributor

Summary

  • Move timeout_timestamp to last position.
  • Rename timeout_timestamp to some name that indicates that it is a relative time.
  • Remove timeout_height.
  • Adjust ValidateBasic (remove check on timeout height).

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added this to the v6.0.0 milestone Sep 8, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Sep 8, 2022
@damiannolan damiannolan mentioned this issue Sep 9, 2022
Merged
9 tasks
@chatton chatton self-assigned this Sep 13, 2022
@chatton chatton mentioned this issue Sep 13, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega moved this from Todo to In review in ibc-go Sep 16, 2022
Repository owner moved this from In review to Done in ibc-go Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chatton chatton

Labels
27-interchain-accounts
Projects
ibc-go
Archived in project
Milestone
v6.0.0
Development

Successfully merging a pull request may close this issue.

Modify MsgSendTx fields based on audit cosmos/ibc-go
3 participants
@crodriguezvega @chatton @colin-axner