-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ics-31-crosschain-queries #2181
Comments
Hi @Woojinger. Great to hear that you want to contribute to IBC. Would your implementation of ICS31 be in any way different than the one that already exists? I think this implementation is the one that follows the ICS31 standard, so if your application would not deviate from ICS31, then I think it would make sense that you contribute to that implementation instead of creating a new one. As you say, that will prevent duplication of code and will help to concentrate the efforts. |
Hello @crodriguezvega. The implementation is about relayer and uses go. But what we're making is IBC-go module(31-ibc-query) and relayer by using Rust. So I think it is little hard to contribute to that implementation.. sorry |
Hi @Woojinger. Ok, I see... So if you're working on a different implementation of ICS31, what are your long term plans for it? I am asking because we are considering at the moment restructuring the ibc-go repository and break it up into three separate repos: one for core, one for applications/middlewares, and one for light clients. If you are interested in the future to upstream your implementation, then you could add it to the applications repo and be the maintainer of it. Would this approach be suitable for you? We are also at the moment maintaining a registry of apps in the readme of ibc-go, so if you prefer to keep the app in your own repository, then we could list it there. Would you have any preference between these two approaches? Since there is no changes needed for ibc-go, I will close this issue for now, but please feel free to comment if you have any feedback or thoughts regarding the above. Thanks! |
@crodriguezvega |
Hey @Woojinger, sorry for the late reply. We have been discussing internally in the team and we have decided to go in a different path: instead of creating a new repo where applications could be added, we are considering the following two options for external teams:
How does this sound? Looking forward to your feedback! |
Thank you @crodriguezvega We choose first option and we will set up our module like this example When we finish our setup, I will reply again in this issue and contact IBC product team. our new repository link Thank you! |
Hello, I tried to find a contact detail for you, @Woojinger but was not successful so feel free to send me an email on [email protected] and we can discuss the product use cases. Looking forward to it! |
Summary
Our team tries to implement ics-31-crosschain-queries
Forked IBC-go link
Forked IBC Relayer link
We want to know how to contribute code without duplication with other teams
Problem Definition
Hello, I’m a member of Decipher, Blockchain Research Group based in Seoul National University
Some developers in Decipher felt a need for crosschain-queries and we started to implement it.
But we found another team repo for interchain-queries in README a few days ago. So we are confused as to whether we can continue to work on our repo.
How can we contribute?
Proposal
For Admin Use
The text was updated successfully, but these errors were encountered: