Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UpgradeError rpc to 04-channel query service #1901

Closed
3 tasks
damiannolan opened this issue Aug 6, 2022 · 3 comments
Closed
3 tasks

Add UpgradeError rpc to 04-channel query service #1901

damiannolan opened this issue Aug 6, 2022 · 3 comments
Assignees

Comments

@damiannolan
Copy link
Member

damiannolan commented Aug 6, 2022

Summary

Return the ErrorReceipt stored in state for the provided port and channel identifiers.

  • Add the request and response protobuf message types for querying error receipts.
  • Add the UpgradeError rpc to the Query service.
  • Implement the query handler in the 04-channel submodule.
rpc UpgradeError(QueryUpgradeErrorRequest) returns (QueryUpgradeErrorResponse) {
    option (google.api.http).get = "/ibc/core/channel/v1/channels/{channel_id}/ports/{port_id}/upgrade_error";
}

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added this to the 04-channel upgrades alpha milestone Aug 6, 2022
@damiannolan damiannolan mentioned this issue Aug 6, 2022
10 tasks
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Aug 19, 2022
@crodriguezvega crodriguezvega moved this from Backlog to Todo in ibc-go Sep 22, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Nov 1, 2022
@charleenfei charleenfei moved this from Todo to In progress in ibc-go Mar 28, 2023
@charleenfei charleenfei self-assigned this Mar 28, 2023
@charleenfei charleenfei moved this from In progress to In review in ibc-go Mar 29, 2023
@charleenfei charleenfei moved this from In review to Done in ibc-go Apr 3, 2023
@colin-axner
Copy link
Contributor

Should we call the grpc ErrorReceipt? To avoid name conflict with the UpgradeError type?

@colin-axner
Copy link
Contributor

It looks like this issue can be closed?

@damiannolan
Copy link
Member Author

Yep, let's close this. Looks like it slipped under the radar as merges to feat branch don't auto close the issue.

Implemented in #3367

@github-project-automation github-project-automation bot moved this from Done to Todo in ibc-go Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants